Skip to content

Update docs to use top-level CMake targets #12807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jul 29, 2025
Merged

Update docs to use top-level CMake targets #12807

merged 47 commits into from
Jul 29, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 24, 2025 •
edited
Loading

Update the "Building from Source" and "Using ExecuTorch with C++" docs to specify the top-level CMake targets. I also added some info to the selective build docs to document the CMake flags which control selective build with the executorch_kernels target.

This is done in the context of top-level CMake targets, tracked in #12293.

GregoryComer and others added 11 commits July 21, 2025 14:38
@GregoryComer
Update
7c0481e 
[ghstack-poisoned]
@GregoryComer
Update
d562557 
[ghstack-poisoned]
@GregoryComer
Update
295206e 
[ghstack-poisoned]
@GregoryComer
Update
1a6d403 
[ghstack-poisoned]
@GregoryComer
Update
9a9d56c 
[ghstack-poisoned]
@GregoryComer
Update
9b1cd87 
[ghstack-poisoned]
@GregoryComer
Update
91792fd 
[ghstack-poisoned]
@GregoryComer
Update
c6d1ff2 
[ghstack-poisoned]
@GregoryComer
Update
1f9ab62 
[ghstack-poisoned]
@GregoryComer
Update
533901d 
[ghstack-poisoned]
@GregoryComer
Update
ba46772 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 24, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12807

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e9af248 with merge base a70b7a8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 24, 2025
@GregoryComer
Update docs to use top-level CMake targets
ac7fff8 
ghstack-source-id: 9877dbf
ghstack-comment-id: 3111967018
Pull-Request: #12807
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2025
This was referenced Jul 24, 2025
Merged
Merged
Merged
@GregoryComer
Update
c3a6a73 
[ghstack-poisoned]
@GregoryComer
Update
1816540 
[ghstack-poisoned]
@GregoryComer
Update
046b989 
[ghstack-poisoned]
@GregoryComer
Update
70ba5b7 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 24, 2025
@GregoryComer
Update docs to use top-level CMake targets
f409f5f 
ghstack-source-id: 8e1d39e
ghstack-comment-id: 3111967018
Pull-Request: #12807
@GregoryComer
Update
25e18d7 
[ghstack-poisoned]
@GregoryComer
Update
8ae3a4e 
[ghstack-poisoned]
@GregoryComer
Update
09fd5fc 
[ghstack-poisoned]
@GregoryComer
Update
5244f91 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 24, 2025
@GregoryComer
Update docs to use top-level CMake targets
43523a6 
ghstack-source-id: a1fcb32
ghstack-comment-id: 3111967018
Pull-Request: #12807
@GregoryComer
Update
4e244ab 
[ghstack-poisoned]
@mergennachin
Copy link
Contributor

cc @lucylq

@GregoryComer
Update
d2bdf8b 
[ghstack-poisoned]
@GregoryComer
Update
fab6b9d 
[ghstack-poisoned]
@GregoryComer
Update
73c2cb0 
[ghstack-poisoned]
@GregoryComer
Update
7507aa2 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 28, 2025
@GregoryComer
Update docs to use top-level CMake targets
d277530 
ghstack-source-id: 4da6ffe
ghstack-comment-id: 3111967018
Pull-Request: #12807
@GregoryComer
Update
f7d413f 
[ghstack-poisoned]
@GregoryComer
Update
65087f5 
[ghstack-poisoned]
@GregoryComer
Update
9d1824d 
[ghstack-poisoned]
@GregoryComer
Update
c7786c1 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 28, 2025
@GregoryComer
Update docs to use top-level CMake targets
5ab6e35 
ghstack-source-id: 880222b
ghstack-comment-id: 3111967018
Pull-Request: #12807
@GregoryComer
Update
b3944b3 
[ghstack-poisoned]
@GregoryComer
Update
56f84cc 
[ghstack-poisoned]
@GregoryComer
Update
1d1391d 
[ghstack-poisoned]
@GregoryComer GregoryComer requested a review from SS-JIA as a code owner July 28, 2025 23:21
GregoryComer added a commit that referenced this pull request Jul 28, 2025
@GregoryComer
Update docs to use top-level CMake targets
d434c73 
ghstack-source-id: 27e29ab
ghstack-comment-id: 3111967018
Pull-Request: #12807
@GregoryComer
Update
42c53a6 
[ghstack-poisoned]
@GregoryComer
Update
2a5ab06 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 29, 2025
@GregoryComer
Update docs to use top-level CMake targets
4891154 
ghstack-source-id: 1abc70a
ghstack-comment-id: 3111967018
Pull-Request: #12807
Base automatically changed from gh/GregoryComer/89/head to main July 29, 2025 06:10
@GregoryComer
Update
e9af248 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 29, 2025
@GregoryComer
Update docs to use top-level CMake targets
eea743d 
ghstack-source-id: bd444bf
ghstack-comment-id: 3111967018
Pull-Request: #12807
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer merged commit da8af21 into main Jul 29, 2025
106 of 112 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/90/head branch July 29, 2025 16:37
@lucylq lucylq mentioned this pull request Jul 30, 2025
Merged
@lucylq
Copy link
Contributor

lucylq commented Jul 30, 2025

Can we CP this to 0.7, do these changes only reflect code in main?

larryliu0820 pushed a commit that referenced this pull request Jul 30, 2025
@lucylq
Release 0.7 doc (#12967)
29cc070 
added some changes for flat_tensor build, but realized these are updated
on main here: #12807, though I
don't think the code-changes are in main.

otherwise just a few nits.
@GregoryComer
Copy link
Member Author

Can we CP this to 0.7, do these changes only reflect code in main?

The actual CMake changes aren't in 0.7, so this should probably wait for 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@lucylq lucylq Awaiting requested review from lucylq

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregoryComer @mergennachin @lucylq @facebook-github-bot